search

scelis / twine

Twine is a command line tool for managing your strings and their translations.
Other
840 stars 151 forks source link

[Version 1.0.3] Not Specifying --format in consume-localization-archive exists cleanly #243

Closed danl3v closed 6 years ago

danl3v commented 6 years ago

When updating twine, we did not specify --format when calling consume-localization-archive, which logged the following output. These lines have an exit code of 0. It would be helpful if this had a non 0 exit code so that our scripts will fail next time.

Thanks!

Unable to determine format. Candidates are: android, tizen. Please specify the format you want using '--format'
Unable to determine format. Candidates are: android, tizen. Please specify the format you want using '--format'
Unable to determine format. Candidates are: android, tizen. Please specify the format you want using '--format'
Unable to determine format. Candidates are: android, tizen. Please specify the format you want using '--format'
Unable to determine format. Candidates are: android, tizen. Please specify the format you want using '--format'
Unable to determine format. Candidates are: android, tizen. Please specify the format you want using '--format'
Unable to determine format. Candidates are: android, tizen. Please specify the format you want using '--format'
Unable to determine format. Candidates are: android, tizen. Please specify the format you want using '--format'
Unable to determine format. Candidates are: android, tizen. Please specify the format you want using '--format'
Unable to determine format. Candidates are: android, tizen. Please specify the format you want using '--format'
Unable to determine format. Candidates are: android, tizen. Please specify the format you want using '--format'
Unable to determine format. Candidates are: android, tizen. Please specify the format you want using '--format'
Unable to determine format. Candidates are: android, tizen. Please specify the format you want using '--format'
Unable to determine format. Candidates are: android, tizen. Please specify the format you want using '--format'
Unable to determine format. Candidates are: android, tizen. Please specify the format you want using '--format'
Unable to determine format. Candidates are: android, tizen. Please specify the format you want using '--format'
Unable to determine format. Candidates are: android, tizen. Please specify the format you want using '--format'
Unable to determine format. Candidates are: android, tizen. Please specify the format you want using '--format'
sebastianludwig commented 6 years ago

Hey @danl3v, thanks for bringing this issue to our attention! We've got two options here:

A) Abort the whole archive consumption as soon as one file fails B) Exist with a non zero code if at least one import failed, even though all others might have succeeded

I think B is the way to go. @scelis?

danl3v commented 6 years ago

Thanks for the notes! I am happy either way.