scelis / twine

Twine is a command line tool for managing your strings and their translations.
Other
840 stars 151 forks source link

[1.0.4] Html Tags with No Characters In Between Get Mangled #253

Closed danl3v closed 6 years ago

danl3v commented 6 years ago

If you're reporting a bug, please do the following:

[[Test]]
    [String]
        en = <b/>
sebastianludwig commented 6 years ago

Thanks Daniel for raising this issue đź‘Ť

However I'm inclined to to close it as Won't Fix until it's a real problem for someone. I suspect it's REXML's .to_s that collapses the tags. SO suggests that an injected empty string content would preserve the closing tag. But...phew...looks like complexity without real benefit to me. @scelis?

scelis commented 6 years ago

Hmm, I tend to agree. If this is caused by REXML and there's no way to configure it differently, I think using something like a zero width space character is a valid workaround.

danl3v commented 6 years ago

Yeah we found the same thing and couldn’t find a fix after looking into the docs for REXML. I am find closing. We shouldn’t have empty tags of html anyways

danl3v commented 6 years ago

Thanks for looking into it!