Twine no longer supports iOS Language Codes for Traditional and Simplified Chinese

[danl3v]

If you're reporting a bug, please do the following:

• Mention the Twine version you're using b1f629061a4b9a3b094ecbf4050a1a2c6f24f939

• Provide a minimal but complete input file causing the error (inline with triple ` is fine)

  [[Strings]]
  [S_String]
      en = Hello world
      zh-Hans = Translated String

• Quote the exact twine command that's being run

  twine generate-localization-file twine.txt zh-Hans.xml --format android

• Provide the complete expected output (again, inline is fine) I expect this to generate an xml file, but as of 094ba47ac8e60005271f6daf6706144058c87e03 this fails even though Apple generates this language code when you add Simplified Chinese to an Xcode Project.

Is there a reason language codes need to be ISO-631 codes? By just doing string matching between files you could allow people to use any arbitrary string. Maybe I have an app that doesn't use standard language codes, but I still want to use twine?

It seems that Apple is not strictly using ISO-631 since Simplified and Traditional Chinese cannot be represented with ISO-631: https://www.loc.gov/standards/iso639-2/faq.html#23

Here is the actual output:

Unable to determine language for zh-Hans.xml

[danl3v]

Thanks for looking into this!

[danl3v]

Reverting https://github.com/scelis/twine/commit/094ba47ac8e60005271f6daf6706144058c87e03 locally fixed things for us. Not sure if you want to fix forward, or if you want to revert this commit until a solution can be found.

[sebastianludwig]

Hey Daniel, sorry for not responding earlier. I'm pretty busy this week and will try to come up with a solution over the weekend. But thanks for investigating so far!

[danl3v]

Thanks! We appreciate it. Does reverting that commit and tagging a new version make sense for now to unblock any iOS folks using twine?

[danl3v]

I opened up a PR to revert the change: https://github.com/scelis/twine/pull/256. Would be great if this could be merged to unblock us. We can build off of a fork in the meantime

[sebastianludwig]

Hey Daniel, I've just opened #257 to fix the issue. I know it's too late now, but specifying the language with --lang would have helped in the meantime. I've also added this hint to the error message to hopefully prevent anyone from being blocked by such errors in the future.