search

scemino / engge

Open source remake of Thimbleweed Park's engine
https://scemino.github.io/
MIT License
148 stars 15 forks source link

Observed failures in the execution of two scripts #113

Closed Mac1512 closed 4 years ago

Mac1512 commented 4 years ago

I have observed errors in the execution of two scripts, these are not saved in the log, and I cannot determine what is causing them, so I pass you two screenshots in case they are useful.

Script error 1:

fallo_script1

This may have to do with the tutorial not running correctly, but I'll open an issue about it.

Script error 2:

fallo_script2

Regards

scemino commented 4 years ago

The first script error is easy to reproduce, but the second one... how can I reproduce it ?

Mac1512 commented 4 years ago

The second error has only given me once and I do not know how to reproduce it again, perhaps it is a point error.

The fact is, I was driving actor Ray or Reyes, where the body was in the Bridge room, when that bug came out. I know I tried many options or else with the body, poster, light ... I don't know, since when I realized it, it had come out. Perhaps I would have blocked the console window to capture the first failure and then this one came out ... or it was for any other reason, since I have not been able to reproduce it again in new tests that I have carried out.

So at the moment I can not be of help in the face of this failure, if in the future I see it again, I will comment here.

Mac1512 commented 4 years ago

I have seen that with this commit:

Fix findScreenPosition called with an object as argument https://github.com/scemino/engge/commit/ffcfb38020fc855ca05464c7f1cc949881772732

This error has occurred:

fail_double_screen

Mac1512 commented 4 years ago

What I said in the previous post, is resolved in this commit https://github.com/scemino/engge/commit/345add1e5aacdbac5af060bf9c2ad9ac4a2f07e4, although many other failures arise, such as, One actor cannot give an object to another, the height of the texts that the actors say is now incorrect, it has also been generated new layer errors. For example:

fallo_layer_interior_sheriff

Now willie if he snores, you see the text and you hear him snore, although his head blinks and he continues to see the text "snore" even if Boris advances to the right and stops seeing Willie.

I guess maybe part of these bugs you already know, so I'll wait for new commits, before opening new issues

scemino commented 4 years ago

If you agree @Mac1512, I can close this issue, the first script error has been fixed (and the regression) and I can't reproduce the second script error. If it happens again, just open a new issue.

Mac1512 commented 4 years ago

Yes, I think it is the right thing to do. If this error appears again, it will reopen an issue