search

scemino / engge

Open source remake of Thimbleweed Park's engine
https://scemino.github.io/
MIT License
148 stars 15 forks source link

engge closes unexpectedly when accessing the options menu or saving game, normally the second time #167

Closed Mac1512 closed 4 years ago

Mac1512 commented 4 years ago

Describe the bug

engge closes unexpectedly when accessing the options menu or saving game, normally the second time

To Reproduce

Testing the commit:

Fix call a callback when exiting elevator (https://github.com/scemino/engge/commit/aeb37dae999a0187eb837858dd4839b22ee7ec93)

engge closes unexpectedly when accessing options or when saving a game, usually the second time, when I try to open the options menu or when saving in a new slot. This I tested at the beginning, part 1, managing Boris. I saved the game after crossing the door, and when saving again in the same area, engge has closed unexpectedly, no error is observed in the log.

Expected behavior

Screenshots

Desktop (please complete the following information):

Additional context

scemino commented 4 years ago

I can't reproduce it, did you try to remove (or just move in other directory) your savegames? Maybe it comes from a 1 or more corrupted savegames, if it comes from a savegame, can you send it to me, I will try to fix the issue correctly. Thank you.

Mac1512 commented 4 years ago

I can't reproduce it, did you try to remove (or just move in other directory) your savegames? Maybe it comes from a 1 or more corrupted savegames, if it comes from a savegame, can you send it to me, I will try to fix the issue correctly. Thank you.

You are right, the problem is due to a saved game ... maybe some data was corrupted when saving it. I think that when there is a failure a json of the saved game is generated, right?

I have moved the saved games to another location and the problem has been resolved. However, I am sending you the saved games so you can keep an eye on them.

Link:

https://www.mediafire.com/file/nk8ttvmq07eiw01/engge-0.5.0-alpha-win32-saves_fail.7z/file

Cheers :)

scemino commented 4 years ago

With the commit aeb37da, if I load the second savegame you gave me I can reproduce a crash when moving Boris to the body, I can reproduce it each time. With the last commit b0bdea3, there is no crash. So I close this issue if you agree.

Mac1512 commented 4 years ago

I see it correct :)