scenario-labs / Scenario-Unity

The Scenario Unity Plugin allows you to live the Scenario experience directly into Unity
https://www.scenario.com
66 stars 4 forks source link

feat: 109 isometric building workflow #156

Closed TheLLspectre closed 3 months ago

TheLLspectre commented 6 months ago

Adding isometric workflow: Main features:

TheLLspectre commented 5 months ago

Fixing conflicts after merging dev with 125

qvaleroo commented 5 months ago

Step1 window is not correctly sized when opening the first time on my mac:

image

And is it possible to handle errors if models are not available rather than fetch error on console? Maybe we can have an outage or a model change, and we can just display an error message readable for the user, like "Model xxxx not available"?

qvaleroo commented 5 months ago

Select button display on Custom is broken:

image
qvaleroo commented 5 months ago

Select buttons on Step 1 are broken after using the Select option on Custom https://github.com/scenario-labs/Scenario-Unity/assets/95273550/a7bd1bbc-a93e-40d7-ac69-f65598e58e35

qvaleroo commented 5 months ago

Isn't possible to go back to Previous Step? Display of Step2 is not really optimized either. Window cut the content

image
qvaleroo commented 5 months ago

lora1, lora2.... are final names?

image
qvaleroo commented 5 months ago

Is it possible to click on the whole image rather than the little checkbox?

image
qvaleroo commented 5 months ago

Issue with wording here no? No spaces and typo on Contemporary

image
TheLLspectre commented 5 months ago

Step1 window is not correctly sized when opening the first time on my mac: image

And is it possible to handle errors if models are not available rather than fetch error on console? Maybe we can have an outage or a model change, and we can just display an error message readable for the user, like "Model xxxx not available"?

You try to access it whitout the isometric workspace @qvaleroo ?

TheLLspectre commented 5 months ago

Select button display on Custom is broken: image

Thanks @qvaleroo ! I didn't see that !

qvaleroo commented 5 months ago

Step 4 is really hard to understand, I didn't get I had to enter name of building in the field

https://github.com/scenario-labs/Scenario-Unity/assets/95273550/0470efdb-019f-4e97-b1c4-4fa1de9bbb07

qvaleroo commented 5 months ago

I didn't get why after step4 the prompt window automatically opened, or maybe just get in front row if it was open in background 🤔

image
qvaleroo commented 5 months ago

All titles change colour when I hover my mouse on it, we should avoid this as it is just a title (maybe it is only on Mac?)

image
qvaleroo commented 5 months ago

Regarding step5:

https://github.com/scenario-labs/Scenario-Unity/assets/95273550/b6c3153f-146f-4791-b680-9c35270f9ede

TheLLspectre commented 5 months ago

lora1, lora2.... are final names? image

Some models will be removed

TheLLspectre commented 5 months ago

Select buttons on Step 1 are broken after using the Select option on Custom https://github.com/scenario-labs/Scenario-Unity/assets/95273550/a7bd1bbc-a93e-40d7-ac69-f65598e58e35

Not looking broken, if custom image are not filled you can't select it. The select button had a trouble. And same for square if you want to select it the selector goes back to null. May be it's not clear

qvaleroo commented 5 months ago

Select buttons on Step 1 are broken after using the Select option on Custom https://github.com/scenario-labs/Scenario-Unity/assets/95273550/a7bd1bbc-a93e-40d7-ac69-f65598e58e35

Not looking broken, if custom image are not filled you can't select it. The select button had a trouble. And same for square if you want to select it the selector goes back to null. May be it's not clear

In this case we should not be able to click on the Custom checkbox. Currently you can click and see an animation. Checkbox should just be disabled. Then if you click again on a selected checkbox, do not select another one. please leave everything unselect.

TheLLspectre commented 5 months ago

Step 4 is really hard to understand, I didn't get I had to enter name of building in the field Screen.Recording.2024-03-26.at.14.07.40.mov

Yeap, I'm agree, I add a subtitle to add indication... but if you have any idea to improve it ????

qvaleroo commented 5 months ago

Step 4 is really hard to understand, I didn't get I had to enter name of building in the field Screen.Recording.2024-03-26.at.14.07.40.mov

Yeap, I'm agree, I add a subtitle to add indication... but if you have any idea to improve it ????

Maybe we can add buttons above like the prompt builder o nthe web to quickly add building types and understand what it is ? The Add Samples button is little bit mysterious and we don't know what will happen when clicking on it

image
Morgan-6Freedom commented 5 months ago

@qvaleroo which models do we keep for the release in this window ? Could you make sure they will be available publicly before we merge into develop ? image

qvaleroo commented 3 months ago

We should not need the user to fill Workspace ID in settings. If you want the ID, you can have it with /teams endpoint

image
qvaleroo commented 3 months ago

Is it possible to center the text and icon for custom isometric choice?

image
qvaleroo commented 3 months ago

Some icons are empty

image
qvaleroo commented 3 months ago
image

Maybe replace "This consume Credits" by the actual cost value. You can obtain it sending the request with parameter dryRun = true (check with frontend team or backend team if help is needed)

qvaleroo commented 3 months ago

We should also handle Parallel inferences limit. Creator plan is limited to 5 inferences in // for example but I can send more than 5 ifnerences. You should queue the request when receiving a 429 error, and relaunch it once a request is finished for example. You have the max number of allowed parallel inferences using /team/{teamId}/limits endpoint

image
TheLLspectre commented 3 months ago

Some icons are empty image

Some models are not available on download, when you're not on isometric workspace :/