Tableview's didSelectRowAt method not getting called in v1.6.0

Isuru-Nanayakkara commented 5 years ago

Short description

I have a UITableViewController embedded in the floating panel. When I single tap on any cell, the didSelectRowAt method gets fired. But since the latest version, this behavior has become erratic. I have to double tap on cells for the didSelectRowAt method to fire.

Expected behavior

didSelectRowAt method to fire on single tap. This worked fine in v1.4.0.

Steps to reproduce

Have the floating panel initial position has half.
Swipe up to full position and tap on a cell. didSelectRowAt does not fire.
Tap on that cell again. Now the didSelectRowAt fires.

Another behavior I noticed.

Have the floating panel initial position has half.
Swipe up on the floating panel but before it reaches full position, let go so it slides back down.
Now swipe it up fully again.
Tap on a cell and the didSelectRowAt fires.

Environment

Library version 1.6.0

Installation method

[x] CocoaPods
[ ] Carthage
[ ] Git submodules

iOS version(s) 12.2

Xcode version 10.2.1

scenee commented 5 years ago

Could you please check the repro when you comment out the line? (I'd like you to ensure that you rebuild the library after cleaning derived data)

Isuru-Nanayakkara commented 5 years ago

Is it okay to edit the source files even if I add the library to my project via CocoaPods?

scenee commented 5 years ago

Yes, it is!

Isuru-Nanayakkara commented 5 years ago

Tried it. Cleaned the DerviedData folder manually too. But the issue persists.

scenee commented 5 years ago

Thanks, it looks same as https://github.com/SCENEE/FloatingPanel/issues/164. As the comment mentioned, it seems to be an issue of UITableView. I tried to fix it in a couple of days but it's hard to fix it completely..

Isuru-Nanayakkara commented 5 years ago

Oh, that sucks. I guess I'll revert back to v1.4.0 for now. Everything works fine in that version.

scenee commented 5 years ago

Oh, I missed it. This might be not same issue as #164 reported on v1.4.0. I need to investigate this more.

iOS 13 seems to fix the didSelectRowAt issue reported on #164.

HappyIosDeveloper commented 3 years ago

I still have this issue.

scenee / FloatingPanel