search

scenerygraphics / scenery

Flexible VR Visualisation for Volumetric and Geometric Data on the Java VM, powered by Kotlin and Vulkan.
https://scenery.graphics
GNU Lesser General Public License v3.0
131 stars 32 forks source link

Remove the OpenGL renderer #541

Closed skalarproduktraum closed 1 year ago

skalarproduktraum commented 1 year ago

This PR removes the OpenGL renderer together with remaining dependencies on JOGL and ClearGL.

skalarproduktraum commented 1 year ago

@ctrueden So this seems to work well, however the bump to pom-scijava 35.1.1 has broken the REPL tests:

graphics.scenery.tests.unit.repl.REPLTests > testStartupScript FAILED
    javax.script.ScriptException at REPLTests.kt:33
        Caused by: org.codehaus.groovy.control.MultipleCompilationErrorsException at REPLTests.kt:33

graphics.scenery.tests.unit.repl.REPLTests > testEval FAILED
    javax.script.ScriptException at REPLTests.kt:43
        Caused by: org.codehaus.groovy.control.MultipleCompilationErrorsException at REPLTests.kt:43

graphics.scenery.tests.unit.repl.REPLTests > testObjectAccess FAILED
    javax.script.ScriptException at REPLTests.kt:57
        Caused by: org.codehaus.groovy.control.MultipleCompilationErrorsException at REPLTests.kt:57

I had added a param to ScriptREPL a while ago that lets you choose the language upfront. However, this doesn't seem to be heeded anymore, as the REPL straightly goes to Groovy (as seen above). Any ideas why that is?

skalarproduktraum commented 1 year ago

Found the problem: For the script interpreter, what was formerly known as Python is now known as Python (Jython) 👍

ctrueden commented 1 year ago

what was formerly known as Python is now known as Python (Jython)

Ahh yeah, sorry this burned you @skalarproduktraum. The goal was to make way for a "Python (CPython)" language built on PyImageJ. With the Jython language called "Python", it was confusing, so we figured it would be better to be clear in the name...

skalarproduktraum commented 1 year ago

You could have called it... Jython 🙃