search

scenerygraphics / scenery

Flexible VR Visualisation for Volumetric and Geometric Data on the Java VM, powered by Kotlin and Vulkan.
https://scenery.graphics
GNU Lesser General Public License v3.0
129 stars 32 forks source link

RAISource.converterSetups is ArrayList, but should be more general #561

Closed kephale closed 3 months ago

kephale commented 1 year ago

https://github.com/scenerygraphics/scenery/blob/1afdbbb3643676dd60e6049862654b2b8a840e66/src/main/kotlin/graphics/scenery/volumes/Volume.kt#LL221C26-L221C26

I ran into this when trying to write some Java code to create RAISources.

kephale commented 1 year ago

Related to https://github.com/scenerygraphics/sciview/issues/517

skalarproduktraum commented 11 months ago

What's your take? MutableList instead?

kephale commented 11 months ago

Sure, or is there actually a reason to have it be anything other than a List? With a quick skim, I see addAll usage but no actual mutation happening.

skalarproduktraum commented 3 months ago

Fixed in 0.11.2 (408f011b3, to be specific) 👍