scenerygraphics / scenery

Flexible VR Visualisation for Volumetric and Geometric Data on the Java VM, powered by Kotlin and Vulkan.
https://scenery.graphics
GNU Lesser General Public License v3.0
130 stars 32 forks source link

Bump org.slf4j:slf4j-simple from 1.7.36 to 2.0.7 #571

Closed dependabot[bot] closed 1 year ago

dependabot[bot] commented 1 year ago

Bumps org.slf4j:slf4j-simple from 1.7.36 to 2.0.7.

Commits
  • d6a21ae update javadoc plugin to version 3.0.5
  • 13950e5 prepare release 2.0.7
  • 122e0c1 add LICENSE.txt files to all modules, rename LICENSE as LICENSE.txt when appr...
  • 2a8ca99 add license file to jar
  • b363bb3 SLF4J-579: Export client packages of slf4j-api in version 1
  • 2235d3c Fully automate OSGi metadata creation and fix brocken OSGi-metadata in slf4j-...
  • a5540ad setup-java v3
  • 1ed084c add missing distribution instruction to github action
  • b2cb017 update github action versions
  • fa6721a add JDK 19 to CI build
  • Additional commits viewable in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
dependabot[bot] commented 1 year ago

The following labels could not be found: Dependencies.

skalarproduktraum commented 1 year ago

This'll likely lead to issues with scijava. @ctrueden Any plans to move over to slf4j 2.x there?

ctrueden commented 1 year ago

@skalarproduktraum I have no concrete plans to migrate to SLF4J 2.x, but no strong opposition, either. It's just that the last time I tried to update it, some components failed to compile anymore without changes, and I did not (do not) have time to fix it.

What is the reason we need to upgrade to 2.0.7, other than "because it's the latest, and depending on the latest is best practice generally"? If none, then I propose we just wait.

skalarproduktraum commented 1 year ago

To me it looks as if there are going to be no more 1.7.x releases, at least there are none since 2.0 was released. Positive aspects of 2.0 seem to be that it has been modularized. I personally don't mind moving to 2.0, but if it saves you headaches for the moment, @ctrueden, I'm happy to postpone this.

skalarproduktraum commented 1 year ago

Closing this, as not necessary for the moment. I'd consider upgrading should there be any fixes in 2.x that don't make it back to 1.x, e.g. security-related.

dependabot[bot] commented 1 year ago

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.