search

scenerygraphics / scenery

Flexible VR Visualisation for Volumetric and Geometric Data on the Java VM, powered by Kotlin and Vulkan.
https://scenery.graphics
GNU Lesser General Public License v3.0
130 stars 32 forks source link

GLFWMouseAndKeyHandler.kt: Ignore modifier key presses themselves. Th… #576

Closed moreApi closed 1 year ago

moreApi commented 1 year ago

GLFWMouseAndKeyHandler.kt: Ignore modifier key presses themselves. They are already included in events of the other keys

fixes #566

skalarproduktraum commented 1 year ago

What about key bindings to only modifier keys? They'd be ignored now too, right?

moreApi commented 1 year ago

true, but was that possible before?

moreApi commented 1 year ago

I cant not make sense of the codacy error. Maybe it is confused because I am not merging into master. The gitlab error wants us to buy "teams pro" or somehting

moreApi commented 1 year ago

rebased to main @skalarproduktraum

smlpt commented 1 year ago

Works again on my side, thanks for the fix! Just to clarify, Shift + J/K was never supposed to be a default keybind, right? Because that doesn't work.

moreApi commented 1 year ago

Works again on my side, thanks for the fix! Just to clarify, Shift + J/K was never supposed to be a default keybind, right? Because that doesn't work.

Good Question, maybe @skalarproduktraum knows more.