Transfer function editor: Fix colormap reassignment and context menu

scenerygraphics / scenery

Flexible VR Visualisation for Volumetric and Geometric Data on the Java VM, powered by Kotlin and Vulkan.

https://scenery.graphics

GNU Lesser General Public License v3.0

128 stars 31 forks source link

Transfer function editor: Fix colormap reassignment and context menu #701

Closed skalarproduktraum closed 3 months ago

skalarproduktraum commented 4 months ago

This PR fixes two issues:

colormaps would be reassigned on redraw events of ColormapPanel. This was unintended and has been changed to reassign only on actual color map changes.
Right-clicking on the transfer function chart would both open the context menu and draw/modify points. Right-clicking will now only open the context menu.

Fixes #700 and #698.

skalarproduktraum commented 3 months ago

@moreApi Yes, this fixes #698 as well. I've added that to the description. @smlpt I've checked - dragging control points still works for me. Are you certain this PR disables dragging for you?

moreApi commented 3 months ago

nice
maybe its related to https://github.com/scenerygraphics/scenery/issues/377 and an OS issue

skalarproduktraum commented 3 months ago

Cause identified, see https://stackoverflow.com/questions/17441013/mousedragged-not-returning-appropriate-button-down - bottom line is, MouseEvent fired when dragged may or may not contain the button, as there is no state change in the button. Exact behaviour is platform-specific. This is likely unrelated to #377, but I'll check. Thanks for the pointer @moreApi, and thanks for finding this issue, @smlpt 👍