scenerygraphics / scenery

Flexible VR Visualisation for Volumetric and Geometric Data on the Java VM, powered by Kotlin and Vulkan.
https://scenery.graphics
GNU Lesser General Public License v3.0
128 stars 31 forks source link

Pass a fixed sun position to the Atmosphere constructor for reproducability #740

Closed smlpt closed 1 month ago

smlpt commented 2 months ago

The default sun position was influenced by local time, thus screwing with the Argos tests for the AtmosphereExample. This PR solves this bug by passing a fixed sun position vector to the constructur.

skalarproduktraum commented 2 months ago

This is good, but how about adding your keybindings to the example?

smlpt commented 2 months ago

This is good, but how about adding your keybindings to the example?

@skalarproduktraum the keybindings are added in L96

skalarproduktraum commented 1 month ago

Thanks, @smlpt 👍