search

scenerygraphics / sciview

sciview is a tool for visualization and interaction with ND image and mesh data
BSD 2-Clause "Simplified" License
68 stars 17 forks source link

Edit->Settings->Keybindings work does not work #477

Closed moreApi closed 1 year ago

moreApi commented 1 year ago

Copied from zulip:

Jan T: Does Edit->Settings->Keybindings work for you? For me it does nothing, besides the ImageJ status saying : "Running command: key bindings"

Curtis Rueden: @Jan T Testing now...

Curtis Rueden: Also does nothing for me. Debugging...

Curtis Rueden: My poor brain, trying to memorize IDEA keyboard shortcuts on top of Eclipse shortcuts... :exploding_head:

Curtis Rueden: There is an exception, and we never see because we are bitten by scijava/scijava-common#452

Curtis Rueden: It is fixed, but I need to reread to remember how to deal with it.

Curtis Rueden: And then, we will need to fix the actual problem in sciview.

Curtis Rueden: The actual issue is that ui-behaviour's VisualEditorPanel now requires a non-null commandDescriptions, if one is given. But scenery's InputHandler is passing null for this. Probably the fix is to simply use the one-arg VisualEditorPanel constructor where only the config is passed, and the code takes care of constructing a so-called "empty command descriptions" object.

Curtis Rueden: @Jan T Would you care to test? I'm working on something else... all you need to do is change line 317 of InputEditor.kt to remove the , null argument, rebuild and link to sciview, and see if things work better.

moreApi commented 1 year ago

should be fixed by https://github.com/scenerygraphics/scenery/pull/549