search

scenerygraphics / sciview

sciview is a tool for visualization and interaction with ND image and mesh data
BSD 2-Clause "Simplified" License
68 stars 17 forks source link

Reformatting, use deleteNode when disposing #478

Closed kephale closed 1 year ago

kephale commented 1 year ago

Easy to do later, leaving as WIP during the hackathon because I reformatted too.

ctrueden commented 1 year ago

@kephale I'm happy to split out the formatting part of the commit, if you tell me your preferred way to perform the formatting. Using IntelliJ, presumably? Do I need to configure any rules, or does sciview use the default style?

kephale commented 1 year ago

I'm not really picky about formatting in general, but some lines around the main change here were indented wrong so I had to run reformat. I did use IntelliJ and I thought we had some linting rules, but I haven't tracked those details very well.

kephale commented 1 year ago

Replaced by https://github.com/scenerygraphics/sciview/pull/525