scenerygraphics / sciview

sciview is a tool for visualization and interaction with ND image and mesh data
BSD 2-Clause "Simplified" License
67 stars 17 forks source link

Fix: recursive delete calls no longer use activePublish #587

Closed smlpt closed 5 months ago

smlpt commented 5 months ago

This should fix the slow deletion process for large groups of objects. Previously every child node deletion and every recursive call used activePublish = true, which slowed down sciview by a lot.

smlpt commented 5 months ago

Good question, but I'd also assume no.

And I tested this with the Protein you can add via the Add menu. The deletion is almost instant now.

skalarproduktraum commented 5 months ago

I'd agree that if it's known that the parent node is gone is enough 👍

skalarproduktraum commented 5 months ago

Thanks, @smlpt 👍