scepman / install

SCEPman | Cloud-based Certification Authority
https://scepman.com/
10 stars 10 forks source link

Parameterizes VNET and subnet IP ranges. Supports 2 subnets #26

Open ml-sammohite opened 3 months ago

bb-froggy commented 2 months ago

Thank you for your contribution! I think parameterizing these IP ranges is a very good idea, as customers want to avoid IP collisions in their subscriptions. I will definitely merge this.

There's one thing I think could still be improved, though. I rather like to have two separate parameters for the two Subnet ranges instead of the single array. Having the array type suggests you could pass an array of length 1, 2, 3 or anything else, but we need exactly two values. Could you change this or convince me of the advantages of the array? :-) I can also do it if you want.