scepman / scepman-psmodule

PowerShell Module for SCEPman installations
MIT License
2 stars 1 forks source link

Feature request - `-WhatIf` / ShouldProcess on cmdlet `Complete-SCEPmanInstallation` #81

Open o-l-a-v opened 1 month ago

o-l-a-v commented 1 month ago

It'd be useful if Complete-SCEPmanInstallation had a -WhatIf parameter and supported ShouldProcess, to don't actually do any changes, just output what would've been changed. A "read only", if you will.

About -WhatIf and ShouldProcess:

Relevant code:


One could probably achieve this now, at least partially, by only having read only permissions in Entra ID and Azure RM activated? It'd probably throw errors though.

bb-froggy commented 1 month ago

Removing the write permissions is no proper replacement for -WhatIf. If you miss a permission, you'd have unwanted changes. In any case, it probably breaks very early with errors, so you wouldn't really see what is going on.

We have the -WhatIf support in three other CMDlets, but haven't yet implemented it in Complete-SCEPmanInstallation. The main reason for this is that you use Complete-SCEPmanInstallation mostly for new installations where you cannot break anything. And hence we thought other stuff has higher priority. Since you are now asking, we'll raise the priority :-).

o-l-a-v commented 1 month ago

We have a message in our Certificate Master instance that says newer versions requires to re-run Complete-SCEPmanInstallation. Which is why I wish for -WhatIf with Complete-SCEPmanInstallation too. 😊

image

Would be nice to see what new features we're not currently set up to use.