scexao-org / camstack

EDT cam stack - python + minimal imgtake.c
5 stars 2 forks source link

Better handle different number of WCS on same camera depending on observing mode. #12

Closed DasVinch closed 1 year ago

DasVinch commented 1 year ago

Remove WCS systems from class KEYWORDS dictionary and generate them on-the-fly during fill_keywords. They must be placeholdered in the base class, then overriden in the subclass.

Warning: _fill_keywords is only called when you set_camera_mode.

We maintain Subaru legacy WCS format for N_WCS > 1.

I'm concerned with VAMPIRES and having 7 WCS kws (4 new + 3 legacy), we're gonna need to again increase the default number of SHM keywords we haul around (that'll be for Olivier and somewhere in the framegrabber code in due time).

@mileslucas please skim over and merge. Or don't :p.