scexao-org / vampires_dpp

Tools for processing VAMPIRES data
MIT License
3 stars 3 forks source link

Not providing frame_centers crashes #2

Closed maxwellmb closed 1 year ago

maxwellmb commented 1 year ago

The tutorial claims that if you don't provide frame_centers in the calibration file then it'll just pick the middle of the frame, but this doesn't currently work (and there's no evidence in the code that this feature has been implemented).

mileslucas commented 1 year ago

Thanks for the bug report, will investigate.

mileslucas commented 1 year ago

Should be fixed with https://github.com/scexao-org/vampires_dpp/commit/083504204af80a33f44fa27ee05ef04552bcaac5