schacon / hg-git

mercurial to git bridge, pushed to directly from the hg-git plugin in Hg
GNU General Public License v2.0
620 stars 71 forks source link

If python2.4 not supported, needs dependency check in setup, docs. #244

Closed ke1g closed 10 years ago

ke1g commented 12 years ago

Judging by the number of "closed" python2.4 issues, I'm guessing that the decision is that hggit isn't supported on python2.4. If so, setup.py should refuse to install it (it's easy to check the version of python running setup, even if there isn't a better way of specifying the dependency). Also, the page at http://hg-git.github.com/ should prominently mention the restriction in the how to install section, perhaps elsewhere.

(The particular issue I'm hitting, in case you do want to support python2.4, is use of the trinary operator -- true_expr if test_expr else false_expr -- in git_handler.py, in update_hg_bookmarks(), in the calculation of the bms dict. That's line 934 in the released version, but no on tip. The symptom is that hg gets an exception doing status, and probably most other commands, if the extension is enabled.