schacon / hg-git

mercurial to git bridge, pushed to directly from the hg-git plugin in Hg
GNU General Public License v2.0
620 stars 72 forks source link

ssh: fix arg issue with dulwich 0.12.x #316

Closed earies closed 8 years ago

earies commented 8 years ago

It appears commit 032079b1 introduced a method to structure arguments in such a way to be compatible with dulwich 0.11.x. This however breaks in 0.12.x versions. Reverting the above commit and restructuring the join in the git command passed to ssh.

Currently this results in: $ hg --debug -v clone git+ssh://machine.domain.org/code/conf conf calling ssh: ssh machine.domain.org 'g '\''i t - u p l o a d - p a c k '\'' / c o d e / c o n f '\'''\''' Warning: Permanently added '[machine.domain.org]:22,[10.10.10.10]:22' (ECDSA) to the list of known hosts. bash: g: command not found abort: git remote error: The remote server unexpectedly closed the connection.

After reverting: $ hg --debug -v clone git+ssh://machine.domain.org/code/conf conf calling ssh: ssh machine.domain.org 'git-upload-pack '\''/code/conf'\''' Warning: Permanently added '[machine.domain.org]:22,[10.10.10.10]:22' (ECDSA) to the list of known hosts. Counting objects: 3905, done. ...

durin42 commented 8 years ago

https://github.com/schacon/hg-git/blob/master/CONTRIBUTING