search

schacon / showoff

moved to puppetlabs/showoff!
2.41k stars 13 forks source link

Split ALL the h1s #133

Open alexch opened 13 years ago

alexch commented 13 years ago

Testing and refactoring the first part of the "process_markdown" method. I stuck in an implementation of my pet "Split ALL the H1s" feature but I can take it out if you just want the tests for the moment. Or just ignore this pull request until we figure out (and I implement) how to configure it from the top level, or whether we want the feature on all the time (in which case I'd un-break the example preso and stuff).

ALL

alexch commented 13 years ago

ping... this is pretty much working, might could use some more tests but I'm pretty ok with it as is

alexch commented 13 years ago

Just fixed some residual weirdness -- i think i hadn't completely renamed --split_all to simply --split.

Note that because this hasn't been merged yet I'm making my own gem called showoff-alexch so my students and disciples-- uh, I mean colleagues -- can "gem install showoff-alexch" if they want to run my slides with splitting active. I'll try to keep this evil twin gem rebased and up to date with the main one.

alexch commented 12 years ago

I did some major rebasing (and squashing) but somehow this got tied in with my other PR (which was 134 but is now https://github.com/schacon/showoff/pull/154 )

Anyway, just look at https://github.com/alexch/showoff/commit/5f78b23f9b58e9f202e95ed8e06abd2907487d08 which includes just the simple --split option and unit tests.

goncalossilva commented 12 years ago

I like this. However, I believe it would make more sense for it to be an option specified in showoff.json, like this: https://github.com/schacon/showoff/pull/152

Are you willing to make the change?