search

schacon / showoff

moved to puppetlabs/showoff!
2.41k stars 13 forks source link

copying files in url() in CSS is too aggressive in `showoff static` #148

Open jfinkels opened 13 years ago

jfinkels commented 13 years ago

The change introduced by #82, which is commit 9d0097d12e9d94d514b0fbc46afdee16c90e8043, is too aggressive.

There are a few problems with this:

  1. Attempts to copy files from a url() that is commented.

  2. The bigger problem, a url() is not neccesarily a local file. For example, if I want to use Google web fonts, my CSS file has the line

    @import url(http://fonts.googleapis.com/css?family=Mate+SC|Actor);

which is neither an image file nor a local file.

grundprinzip commented 13 years ago

If you intend on using Google Web Fonts you could still download the fonts and load them locally to circumvent this problem.