schacon / showoff

moved to puppetlabs/showoff!
2.41k stars 13 forks source link

Presenter display layout hosed on Firefox 9 and 10 #167

Open durin42 opened 12 years ago

durin42 commented 12 years ago

I did some cursory investigation, but I'm honestly not sure what's up with the layout. It appears to be some disagreement between Webkit and Gecko on how to render the slide div. Seeing this with ffox on OS X, but I'd imagine it happens on other platforms as well.

durin42 commented 12 years ago

I'm not seeing this as entirely fixed - the div containing the presentation is still 1024x768 despite being visually scaled down by 50%. The net result is that the speaker notes are pushed off the bottom of my screen on my MacBook Air.

goncalossilva commented 12 years ago

This is not a fix for the problem, but for the compatibility issues around FF. It's now using the same hack as in Chrome.

The presenter view definitely needs some love.

durin42 commented 12 years ago

Should I open a new issue reflecting the current state of the presenter view in ff?

goncalossilva commented 12 years ago

Does the same issue (notes being pushed off) happen on Chrome/Safari? If yes, please open a new issue. If not, please reopen this one :-)

durin42 commented 12 years ago

It does not occur in Chrome or Safari. I don't have permission to reopen issues, so I can't do so.

goncalossilva commented 12 years ago

Thanks for digging this for me!

bknowles commented 12 years ago

I also noticed problems in presenter mode on Firefox. Is there anything I can do to help debug this issue?

goncalossilva commented 12 years ago

The same problems @durin42 mentioned?

bknowles commented 12 years ago

I believe so. Do you want to see some screencaps?

goncalossilva commented 12 years ago

That would be helpful. That and some CSS fu :p

bknowles commented 12 years ago

Dunno that I can help with the CSS fu, but I can give you some screencaps. These come from doing a showoff presentation of my tutorial at https://github.com/bknowles/chef-fundamentals/tree/flossuk-EDI-2012 which I am preparing to present on the 20th of March in Edinburgh. It shows up okay in Chrome, so while I have other problems with showoff, this particular one isn't a show stopper for me right now.

Anyway, let me now go try to figure out how to upload the screencaps.

bknowles commented 12 years ago

Screencaps uploaded to https://github.com/bknowles/showoff/tree/issue-167/screencaps

durin42 commented 12 years ago

Weird, that's not quite what I'm seeing with master. I'll try to post screenshots later today.

goncalossilva commented 12 years ago

@bknowles are you sure you're testing off master? I committed a work-around to prevent some of your issues on FF: https://github.com/schacon/showoff/commit/a92d2e4e6d1fe6fbceb6bdb1ab8cc4b67577d388

bknowles commented 12 years ago

No, I was testing off the released gem for showoff-0.7.0.

If you can give me some pointers on how to install the current "master" version with all associated dependencies, I'll be glad to re-do my tests and see what comes up.

goncalossilva commented 12 years ago

Sure!

Edit your Gemfile and replace your showoff line with this one: gem "showoff", :git => "git://github.com/schacon/showoff.git"

Run bundle install and bundle exec showoff serve ;)

bknowles commented 12 years ago

So, this is the relevant current contents of /usr/bin/showoff:

gem 'showoff', version load Gem.bin_path('showoff', 'showoff', version)

Can I just replace these two lines with your one line? I'll try that, but I wanted to ask to be sure.

goncalossilva commented 12 years ago

No, no! The file you need to edit is the Gemfile, located in the root of your presentation folder.

bknowles commented 12 years ago

The only Gemfile that I have anywhere remotely close to my presentation folder is in the showoff subdirectory that was installed when I forked the showoff repository, so that I could upload my screencaps. I made sure to keep that subdirectory close to the directories where I was doing the presentations, so that I could try to keep all that related work together in my directory structure.

I've been running "showoff serve" manually from the command line, when I was in the appropriate /slides subdirectory of the presentation I was working on -- either from the subdirectory corresponding to https://github.com/bknowles/zero-to-cloud/tree/master/slides or from the subdirectory corresponding to https://github.com/bknowles/chef-fundamentals/tree/master/slides

goncalossilva commented 12 years ago

Ok, one of your presentations has a Gemfile: https://github.com/bknowles/chef-fundamentals/blob/master/Gemfile

Just change the line I wrote before, run bundle install, and use bundle exec showoff serve.

bknowles commented 12 years ago

Aw, crap. I completely missed that Gemfile. And I hadn't copied that over to my other project. Fixing that now.

Let me try the change and see if this fixes stuff, at least with regards to how I presume things should look when using the official version of showoff, instead of the fork that jtimberman created. ;-(

bknowles commented 12 years ago

Okay, well this looks different with Firefox. New screencaps to be uploaded shortly.

bknowles commented 12 years ago

Okay, it is still borked, but now it's borked in a somewhat different way. See https://github.com/bknowles/showoff/tree/issue-167/screencaps

durin42 commented 12 years ago

This is exactly the behavior I'm seeing. I fiddled with firebug a bit, and the div containing the slides (I think it's class="content"?) had a height of 768px despite the transform being applied.

On Mar 9, 2012, at 11:18 AM, Brad Knowles wrote:

Okay, it is still borked, but now it's borked in a somewhat different way. See https://github.com/bknowles/showoff/tree/issue-167/screencaps


Reply to this email directly or view it on GitHub: https://github.com/schacon/showoff/issues/167#issuecomment-4422635

goncalossilva commented 12 years ago

Yeah, it's pretty annoying. FF doesn't implement "zoom:" ATM. I'll try to think of a better work-around.