search

schalkdaniel / compboost

C++ implementation and R API for componentwise boosting
https://schalkdaniel.github.io/compboost/
GNU Lesser General Public License v3.0
24 stars 3 forks source link

Enhance binning for centered base learner #368

Closed schalkdaniel closed 1 year ago

schalkdaniel commented 1 year ago

At the moment, binning must be applied to the two underlying base learners in the same way. So the index vector of bl1 must be the same as the one from bl2. This is ok as long as both rely on the same feature and use binning. But, the training crashes if one uses binning and the other doesn't.

schalkdaniel commented 1 year ago

This is ok, the centering is always done for just one feature so no problem here