search

schams-net / nagios

TYPO3 CMS Extension: Nagios
https://schams.net/typo3/nagios/
GNU General Public License v2.0
2 stars 7 forks source link

TYPO3 v12 compatibility #34

Closed mgerdes-atl closed 1 year ago

mgerdes-atl commented 1 year ago

Hi @schams-net ,

I just installed the first test project in TYPO3 v12 and noticed that the nagios extension is not marked compatible yet.

I tried to use it with TYPO3 v12 PHP 8.1 and PHP 8.2 and got the expected answer.

# Nagios TYPO3 Monitoring Version master - https://schams.net/nagios

EXT:adminpanel-version-12.4.2
EXT:backend-version-12.4.2
EXT:belog-version-12.4.2
EXT:beuser-version-12.4.2
EXT:core-version-12.4.2
EXT:dashboard-version-12.4.2
EXT:extbase-version-12.4.2
EXT:extensionmanager-version-12.4.2
EXT:filelist-version-12.4.2
EXT:fluid-version-12.4.2
EXT:fluid_styled_content-version-12.4.2
EXT:form-version-12.4.2
EXT:frontend-version-12.4.2
EXT:impexp-version-12.4.2
EXT:info-version-12.4.2
EXT:install-version-12.4.2
EXT:lowlevel-version-12.4.2
EXT:nagios-version-master
EXT:opendocs-version-12.4.2
EXT:recycler-version-12.4.2
EXT:redirects-version-12.4.2
EXT:reports-version-12.4.2
EXT:rte_ckeditor-version-12.4.2
EXT:scheduler-version-12.4.2
EXT:seo-version-12.4.2
EXT:setup-version-12.4.2
EXT:tstemplate-version-12.4.2
EXT:typo3_console-version-8.0.3
EXT:viewpage-version-12.4.2
TYPO3:version-12.4.2
APPLICATIONCONTEXT:development/local
PHP:version-8.2.1
TIMESTAMP:1688035003-CEST

Looks good to me so I just adjusted the composer.json constraint.

Maybe you can just publish an new version with this. Otherwise let me know if I can help you.

Regards Markus

schams-net commented 1 year ago

Many thanks for your pull request. ~The extension works in TYPO3 v12 LTS if the TYPO3 installation is set to "LIVE" and warnings and deprecations are suppressed. If "DEBUG" is enabled, a PHP runtime deprecation exception is thrown, see issue #35.~ Turned out that this was a bug in the extension with PHP v8.2 🙂

I opened a milestone to gather the required changes to make the extension TYPO3 v12 LTS compatible. You're more than welcome to contribute.

mgerdes-atl commented 1 year ago

Hi @schams-net , nice work. You already resolved all milestone issues, nothing left for me ;-)

Just noticed a hint in packagist: There is no license information available for the latest version (v4.0.1) of this package. Maybe you could add the info of the license.

schams-net commented 1 year ago

nice work. You already resolved all milestone issues, nothing left for me ;-)

Some testing would be awesome and highly appreciated 😁

mgerdes-atl commented 1 year ago

Hi @schams-net , thanks for publishing 4.1.0. I'll try to get the new version into some of or TYPO3 v11 and later in TYPO3 v12 and provide some short feedback.