scharch / SONAR

Software for Ontogenic aNalysis of Antibody Repertoires
GNU General Public License v3.0
17 stars 10 forks source link

igphyml wrapper crashes when given custom V library #5

Closed ressy closed 4 years ago

ressy commented 4 years ago

I get this exception when trying to use the --lib option to sonar igphyml:

Traceback (most recent call last):
  File "/SONAR/phylogeny/3.2-run_IgPhyML.py", line 358, in <module>
    if not os.path.isfile(arguments['-lib']):
KeyError: '-lib'

I think there's a missing second dash in a few places for the lib argument:

if arguments['--lib'] is not None:
    if not os.path.isfile(arguments['-lib']):
        sys.exit("Can't find germline file %s" % argument['-lib'])

It works if I replace that with:

if arguments['--lib'] is not None:
    if not os.path.isfile(arguments['--lib']):
        sys.exit("Can't find germline file %s" % argument['--lib'])

(This is in https://github.com/scharch/SONAR/blob/master/phylogeny/3.2-run_IgPhyML.py#L365)

scharch commented 4 years ago

Yeah, sorry about that. Fixed in commit 4625c29

ressy commented 4 years ago

Thanks!