schatekar / IdentityServer4.MultiTenant

A sample implementation of Identity Server 4 with URL based multi-tenancy implementation
28 stars 7 forks source link

Any chance of getting this to work with the released version of IdentityServer4? #2

Open MagnusJohansson opened 7 years ago

MagnusJohansson commented 7 years ago

Hi,

was looking forward to look into and test it, but it doesn't work with IDS4 v1+ (lacking the InMemory/InMemoryUserLoginService namespaces since v1.0)

Any chance of getting this sample to work with IDS4 "proper" ?

schatekar commented 7 years ago

@MagnusJohansson I had put this together as an example of how to implement a multi-tenant identity server using IDSRV4. I never thought anyone would find it useful beyond inspiration. But if you are finding this useful, I am happy to look into bumping the version of IDSRV up, just let me know.

Note that I may not be able to do it right away. Perhaps over the weekend.

ovidiaconescu commented 6 years ago

I've done a quick fork on saaskit to get it working on netcoreapp2.0 Now builder.UseCookieAuthentication(new CookieAuthenticationOptions is Obsolete.

I am trying to obtain the same effect using a set of transient services that overwrite the configuration every time it is needed.

See the PR here: https://github.com/saaskit/saaskit/pull/96

Let me know what you think @schatekar. Thanks!

schatekar commented 6 years ago

@ovidiaconescu LGTM

Transient services are better from a unit testing point of view too.

himalpatel81 commented 6 years ago

@schatekar Did you get chance to post your example ? I'm working on making my app to work with Identity Server and Multitenant. and running into different issues. Hopefully your solution can give some hints.

schatekar commented 6 years ago

@himalpatel81 No, I have not. What issues are you running into?

himalpatel81 commented 6 years ago

@schatekar I've followed the code given at https://github.com/saaskit/saaskit/pull/96/files. I've got two different tenants. The code identifies the tenant properly using the host name. However, when I try to hit the openid-configuration endpoint it fails with 404.

If I remove the Multitenancy, then it works fine. So not sure what am i doing wrong.