search

scheb / two-factor-bundle

[ABANDONED] Two-factor authentication for Symfony 2 & 3 applications 🔐. Please use the newer versions from https://github.com/scheb/2fa.
https://github.com/scheb/2fa
MIT License
386 stars 111 forks source link

Q: Symfony Flex and Symfony 4 Support #100

Closed kironet closed 6 years ago

kironet commented 6 years ago

Hey,

this is really useful bundle. Are you planing to support Symfony Flex and Symfony 4?

scheb commented 6 years ago

I haven't developed on Symfony for quite a while now. What needs to be done to make it compatible with Symfony Flex? Do you know any good resources about it?

cordoval commented 6 years ago

I think symfony will support regular configuration bundles so no need for this imo 👎

Spomky commented 6 years ago

@kironet there is no change to do here. You can submit a new package on https://github.com/symfony/recipes-contrib

xabbuh commented 6 years ago

Well, you may want to declare compatibility with 4.0 versions of the Symfony components you depend on.

cordoval commented 6 years ago

why the bundle has to declare compatibility, @Spomky says there is no change here, wtf?

Spomky commented 6 years ago

The question is about Symfony Flex support, not Symfony 4 support.

eman1986 commented 6 years ago

From what I seen, you just need to whip up a manifest.json file and that should be all you need to do.

I'm using flex at the moment for a new project.

kironet commented 6 years ago

Sorry, yeah I meant to add it here https://github.com/symfony/recipes-contrib And of course, Symfony 4 will be out soon so it will be nice to make it compatible with 4.0.

xabbuh commented 6 years ago

@Spomky @cordoval You are both right. Technically, just to support Symfony Flex there is nothing to do here (in case there is no sensible default configuration that could be shipped for the user). However, since most users will probably start using Flex with Symfony 4 declaring compatibility with Symfony 4 would be a good move forward. But that could as well be part of a separate issue.

cordoval commented 6 years ago

i changed my mind 👍 i am up for this change, just because there may be some changes that in symfony4.0 are needed like constraints on composer.json, going to work on a PR, please help me @xabbuh or surpass me by sending a PR, but either way i just want to help 👴

cordoval commented 6 years ago

addressing in https://github.com/scheb/two-factor-bundle/pull/102

cordoval commented 6 years ago

notice we don't necessarily need a recipe, i think we shouldn't force it, bundles are open and they not need to necessarily coerce usage. So just updating it to symfony 4.0 is fine.

cordoval commented 6 years ago

@scheb it can be closed now i guess?