search

scheb / two-factor-bundle

[ABANDONED] Two-factor authentication for Symfony 2 & 3 applications 🔐. Please use the newer versions from https://github.com/scheb/2fa.
https://github.com/scheb/2fa
MIT License
385 stars 111 forks source link

Use of NullLogger when no logger is set #268

Closed Spomky closed 4 years ago

Spomky commented 4 years ago

With this small change, the property $logger is always set even if no logger is passed in the constructor. The NullLogger has no effect, but its use avoid multiple variable checks.

scheb commented 4 years ago

Looks good, less ifs is better :) Thanks!