search

scheb / yahoo-finance-api

PHP client for Yahoo Finance API 📈
MIT License
279 stars 55 forks source link

why is env => datatables needed to build query in creaturl? #3

Closed matzke closed 7 years ago

matzke commented 8 years ago

do i need to pass this parameter? is there an alternative, when datatables org is down!?


createUrl($query)
    {
        $params = array(
            'env' => "http://datatables.org/alltables.env",
            'format' => "json",
            'q' => $query,
        );
        return "http://query.yahooapi
}```
scheb commented 8 years ago

I don't remember any more, what this parameter is for. Has been a while since I create that library. If you find a way to do queries without that parameter, feel free to send me a PR.

Taronyuu commented 7 years ago

@scheb, you may want to close this issue since it may be confusing. I just forked your repository to update the env parameter until I saw that you already did that 5 days ago. 😄

scheb commented 7 years ago

Jep, they seemed to have changed the call, I've seen it when my stock panel didn't work any more. So I updated it recently.

Taronyuu commented 7 years ago

Yeah same here, we lost a lot of data unfortunately. The current call doesn't return nearly as much as the previous one. However nothing we can do about it.

scheb commented 7 years ago

@Taronyuu Look here, I guess that's why you're missing some data: https://github.com/scheb/yahoo-finance-api/pull/7