Feature/add stock options functionality

scheb / yahoo-finance-api

PHP client for Yahoo Finance API 📈

MIT License

279 stars 55 forks source link

Feature/add stock options functionality #50

Closed CompoTypo closed 7 months ago

CompoTypo commented 7 months ago

This branch contains a small refactor for cookie and crumb acquisition as well as the primary feature of a getStockOptions method.

I have been using this package for quite a while now and love it. I have been getting more into options and I would like to enhance my own personal trading info infra by adding onto this library.

I tried my best to stick to the conventions laid out in the API/decoder and followed the formatting and checks as described in the CONTRIB. Hopefully it is up to standard.

If you have any recommendations or questions, please don't hesitate to comment.

Best, Compo

CompoTypo commented 7 months ago

Thank you for the positive words! I do recommend re-reviewing the work since the models are expanded upon greatly since the initial pr. Thank you for your patience. Please let me know if there are any new issues.

scheb commented 7 months ago

Wow, you really did a great effort with the unit tests, thank you!

Would you please rename the integration tests to match the naming pattern as described here? -> https://github.com/scheb/yahoo-finance-api/blob/4.x/CONTRIBUTING.md#creating-a-pull-request
Psalm has some complaints (see build), would you please handle those?
Adding an example call to the README.md would be great 👍

Other than that, I'd be happy to merge that in.

CompoTypo commented 7 months ago

I squashed another commit on top. The changes should take care of those few requests. Have a great weekend!

scheb commented 7 months ago

Thank you for your work. Has been released under v4.10.0