search

scheb / yahoo-finance-api

PHP client for Yahoo Finance API 📈
MIT License
280 stars 56 forks source link

correct issue getHistoricalQuoteData-start-to-give-401-unauthorized-#52 #54

Closed jrodriguesd closed 3 weeks ago

jrodriguesd commented 3 weeks ago

Description

scheb commented 3 weeks ago

Would you have a look at the code style issues? Is guess running php-cs-fixer would likely solve half of it.

jrodriguesd commented 3 weeks ago

Dear Sir. I don't know how to solve Codecov Issue. Best regards

scheb commented 3 weeks ago

Looks good! From what I can see, the method private function getHistoricalDataResponseBody seems to be dead code and should be removed. (Or you put your implementation in there and remove the getHistoricalDataResponseBodyJson method. However you like).

The historicalData.csv, dividendData.csv and splitData.csv fixture files should also be removed, since it's no longer needed.

You can't do anything about the Codecov issue, you don't need to worry about that.

jrodriguesd commented 3 weeks ago

Dear Sir. Ready. 

Thank you for your guidance. 
Do I need to create another PR?

Best Regards
scheb commented 3 weeks ago

Thank you for solving this issue! A lot of people are going to love this.

Release as v4.11.0.