schedjoules / ios-public-calendars-sdk

MIT License
6 stars 2 forks source link

18 refactor localization v2 #23

Closed Edhoru closed 5 years ago

Edhoru commented 5 years ago

This is the second version of the PR, the first one here: https://github.com/schedjoules/ios-public-calendars-sdk/pull/19 got too dirty from the adding and removing of crashlytics and an app icon which were added since they were needed to be able to send beta builds of the app.

This Pr also includes the resolutions of the comments that were still unresolved from the previous PR.

Regarding comment: https://github.com/schedjoules/ios-public-calendars-sdk/pull/19#issuecomment-451436950 about a subdirectory called New Group, that change was caused by the duplicated commits caused when rebasing master into the feature branch. That's one of the reasons to create a new PR.

Refactor localization and test by changing the device settings

Fixes #18

dmfs commented 5 years ago

Already part of #25