search

scheinem / MSCMoreOptionTableViewCell

Drop-in solution to achieve the "More" button in an UITableView's "Swipe to Delete" menu (as seen in Mail.app under iOS 7)
MIT License
526 stars 60 forks source link

iOS11 beta not showing more button. #37

Open monish152 opened 7 years ago

futuretap commented 7 years ago

Looks like it's not an easy task to fix that. The delete confirmation view that is used to add the custom buttons doesn't exist anymore in iOS 11. Instead, a UISwipeActionPullView is added directly to the UITableViewWrapperView, not the MSCMoreOptionTableViewCell. So we would have to hook into the table view, not the cell.

OTOH, iOS 11 adds its own mechanism for swipable cells (-tableView:trailingSwipeActionsConfigurationForRowAtIndexPath:).

petarov commented 6 years ago

I stumbled upon the same issue today. Found a possible solution in Apple's forums, but yeah, it seems like a real challenge to bring that to iOS11 and lesser versions at the same time.

scheinem commented 6 years ago

Thanks for the link!

I think the best solution would be to improve the documentation and the demo project to show how to use this code for iOS 10 and below and the original Apple solution for iOS 11 at the same time?

What are your thoughts about that?

petarov commented 6 years ago

Thanks for the feedback @scheinem. I'm perfectly fine with that.

I haven't tested the linked solution yet. I'm not a iOS developer, but I do need to make a couple of fixes in an app that uses MSCMoreOptionTableViewCell, so anything works for me at this point. 😉

petarov commented 6 years ago

Solved it by using the gist by @scheinem. Thanks a lot!