search

scheinerman / Permutations.jl

Permutations class for Julia.
Other
51 stars 14 forks source link

Simplify `cycle_string` (get rid of helper function) #33

Closed goggle closed 1 year ago

goggle commented 1 year ago

Simplifies the function cycle_string by creating the string of a cycle directly with Julia's join function instead of using the helper function array2string.

codecov[bot] commented 1 year ago

Codecov Report

Merging #33 (04e43e9) into master (9a24197) will increase coverage by 1.77%. The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master      #33      +/-   ##
==========================================
+ Coverage   83.67%   85.44%   +1.77%     
==========================================
  Files           5        5              
  Lines         490      481       -9     
==========================================
+ Hits          410      411       +1     
+ Misses         80       70      -10
Impacted Files Coverage Δ
src/Permutations.jl 84.33% <0.00%> (+3.32%) :arrow_up:

... and 1 file with indirect coverage changes

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

scheinerman commented 1 year ago

@goggle Thanks for this and the other improvements.