scheinerman / Permutations.jl

Permutations class for Julia.
Other
51 stars 14 forks source link

Combinatorics mandatory? #7

Closed my-little-repository closed 7 years ago

my-little-repository commented 7 years ago

The function nthperm has been moved from Base to the package Combinatorics.jl. Some functions in the Permutations package depend on it.

 julia> Permutation(3,2)
  ERROR: nthperm([1,2,3],2) has been moved to the package Combinatorics.jl.
  Run Pkg.add("Combinatorics") to install Combinatorics on Julia v0.5-
   in nthperm(::Array{Int64,1}, ::Vararg{Any,N}) at ./deprecated.jl:200
   in Permutations.Permutation(::Int64, ::Int64) at /home/yves/.julia/v0.5/Permutations/src/Permutations.jl:40

Everything is fine if Combinatorics is loaded. So maybe the Combinatorics package should be a default dependency of Permutations?

scheinerman commented 7 years ago

Thanks! I’ll be looking at this (and the whole issue of re-tagging … is that the right term?) “soon”. Ed

On Oct 11, 2016, at 08:25, my-little-repository notifications@github.com<mailto:notifications@github.com> wrote:

The function nthperm has been moved from Base to the package Combinatorics.jl. Some functions in the Permutations package depend on it.

julia> Permutation(3,2) ERROR: nthperm([1,2,3],2) has been moved to the package Combinatorics.jl. Run Pkg.add("Combinatorics") to install Combinatorics on Julia v0.5- in nthperm(::Array{Int64,1}, ::Vararg{Any,N}) at ./deprecated.jl:200 in Permutations.Permutation(::Int64, ::Int64) at /home/yves/.julia/v0.5/Permutations/src/Permutations.jl:40

Everything is fine if Combinatorics is loaded. So maybe the Combinatorics package should be a default dependency of Permutations?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/scheinerman/Permutations.jl/issues/7, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AHIqzlbii73_PD3uJz4FQ8Wqv7jhl_ajks5qy4BIgaJpZM4KTkYH.

Edward R. Scheinerman Vice Dean for Education / Professor of Applied Mathematics & Statistics Whiting School of Engineering The Johns Hopkins University 3400 North Charles Street Baltimore, Maryland 21218 USA

Email: ers@jhu.edumailto:ers@jhu.edu Web: http://www.ams.jhu.edu/ers Phone: +1-410-516-7210 (office) +1-410-428-5053 (mobile/text) Appointments: Missy Kirby +1-410-516-7395 or missy.kirby@jhu.edumailto:missy.kirby@jhu.edu Office: Shaffer 103, Homewood Campus

scheinerman commented 7 years ago

OK. this was easily fixed. Still not sure about the broader issue of auto updates and tagging. Very unclear to me!

On Oct 11, 2016, at 08:25, my-little-repository notifications@github.com<mailto:notifications@github.com> wrote:

The function nthperm has been moved from Base to the package Combinatorics.jl. Some functions in the Permutations package depend on it.

julia> Permutation(3,2) ERROR: nthperm([1,2,3],2) has been moved to the package Combinatorics.jl. Run Pkg.add("Combinatorics") to install Combinatorics on Julia v0.5- in nthperm(::Array{Int64,1}, ::Vararg{Any,N}) at ./deprecated.jl:200 in Permutations.Permutation(::Int64, ::Int64) at /home/yves/.julia/v0.5/Permutations/src/Permutations.jl:40

Everything is fine if Combinatorics is loaded. So maybe the Combinatorics package should be a default dependency of Permutations?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/scheinerman/Permutations.jl/issues/7, or mute the threadhttps://github.com/notifications/unsubscribe-auth/AHIqzlbii73_PD3uJz4FQ8Wqv7jhl_ajks5qy4BIgaJpZM4KTkYH.

Edward R. Scheinerman Vice Dean for Education / Professor of Applied Mathematics & Statistics Whiting School of Engineering The Johns Hopkins University 3400 North Charles Street Baltimore, Maryland 21218 USA

Email: ers@jhu.edumailto:ers@jhu.edu Web: http://www.ams.jhu.edu/ers Phone: +1-410-516-7210 (office) +1-410-428-5053 (mobile/text) Appointments: Missy Kirby +1-410-516-7395 or missy.kirby@jhu.edumailto:missy.kirby@jhu.edu Office: Shaffer 103, Homewood Campus