search

schellingb / dosbox-pure

DOSBox Pure is a new fork of DOSBox built for RetroArch/Libretro aiming for simplicity and ease of use.
GNU General Public License v2.0
731 stars 61 forks source link

Force 60 FPS Output Audio Issue since commit a21746a #410

Closed roslof closed 11 months ago

roslof commented 12 months ago

Was trying to pin down an audio issue with dosbox-pure on my Raspberry Pi 4B, and determined the issue started with commit a21746a (Move auto start logic from DBP_PureMenuState into new DBP_Run).

Can test with Amnesia demo (which is a non-commercial software demo). I uploaded a version here: https://drive.google.com/file/d/1Ow0NtFpR-2WHIv6-gPmzXlww5-gh13Hm/view?usp=drive_link

If Force 60 FPS Output is selected, audio becomes corrupt. While Force 60 FPS is unessential here, and the issue can be resolved by turning it off, it's worth noting that all prior commits did not exhibit this behavior. Several of my games which used 60 FPS exhibit the corrupt audio behavior, and turning off 60 FPS resolves the issue.

iconoclusterdotexe commented 11 months ago

I can confirm the issue with x64 version too. There is some audio stuttering every 2-3 seconds when the "Force 60 fps" option is turned on.

I'm using a compiled build with the latest commit.

schellingb commented 11 months ago

Thank you both for reporting this and helping out with testing the main branch, very much appreciated!

The latest commit cbf3703 should revert one change introduced in the commit that broke things which wasn't really necessary anyway. Thanks again for catching this, glad it didn't make it into a release!

roslof commented 11 months ago

A pleasure, @schellingb I confirmed that the fix appears to work. Thank you!

roslof commented 11 months ago

Verified fixed with multiple games including mentioned "Amnesia" demo.