search

schemacrawler / SchemaCrawler-Report-Maven-Plugin

Generate SchemaCrawler reports for Maven generated project websites
Eclipse Public License 2.0
8 stars 6 forks source link

Several problems with Java 17 #13

Closed amseager closed 3 years ago

amseager commented 3 years ago
  1. Seems like the graal-js dependency for graphviz (https://github.com/nidi3/graphviz-java#maven) is now mandatory. I didn't manage to make SchemaCrawler plugin work with J2V8.
  2. If you bind the plugin execution to any of the default maven phases (e.g. prepare-package), it'll stop work too because of doxia errors. Can be fixed by updating doxia-site-renderer to the never version (I've tested with 1.10 while in SchemaCrawler plugin it's 1.7 atm).
sualeh commented 3 years ago

Thanks for the research and information. I will make the required changes, and republish a new version of the Maven report plugin.

sualeh commented 3 years ago

@amseager - I don't see that these changes are needed in the SchemaCrawler Maven plugin itself - they would be in the pom.xml of the project that uses the plugin. If you disagree, I will open up this project to contributions, and request you for a pull request.

amseager commented 3 years ago

Thanks for the answer. I just wanted to highlight these things, and it's definitely possible to solve it by adding the required dependencies manually (that's what I did before reporting on this issue). So I think it's up to you to decide if it needs to be added to the project or not.

sualeh commented 3 years ago

@amseager

  1. I am working on making Graal JS the default for both graphviz-java and for SchemaCrawler scripting. So I will fix this issue.
  2. Please could you submit a pull request to include a dependency to the updated doxia? Thanks.
sualeh commented 3 years ago

Thanks, @amseager! Please submit a corresponding pull request to https://github.com/schemacrawler/SchemaCrawler-Report-Maven-Plugin-Usage-Example

sualeh commented 3 years ago

@amseager - I have released a new version of SchameCrawler (including the Maven plugin). Thanks for your contributions. Please let me know if the new version works for you.

amseager commented 3 years ago

@sualeh Thanks, everything works correctly (tested with 16.15.10.1)