search

schemacrawler / SchemaCrawler

Free database schema discovery and comprehension tool
http://www.schemacrawler.com/
Other
1.6k stars 199 forks source link

15.01.04 causes build to fail on existing command #213

Closed adriens closed 5 years ago

adriens commented 5 years ago

As I tried to upgrade to latest schemacrawler on the csv plugin, the build did not pass :

 getSupportedCommands() has private access in schemacrawler.tools.executable

https://travis-ci.com/adriens/schemacrawler-additional-command-lints-as-csv/builds/87999829

complaining about :

[INFO] -------------------------------------------------------------
[ERROR] COMPILATION ERROR : 
[INFO] -------------------------------------------------------------
[ERROR] /home/travis/build/adriens/schemacrawler-additional-command-lints-as-csv/src/test/java/TestCommandPlugin.java:[16,24] getSupportedCommands() has private access in schemacrawler.tools.executable.CommandRegistry
[INFO] 1 error
[INFO] -------------------------------------------------------------
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------

Is it a normal behavior ...or a regression ?

Thank you in advance for your help.

adriens commented 5 years ago

Fixed in forthcoming version ?

adriens commented 5 years ago

Fixed in 15.01.05 ?

sualeh commented 5 years ago

This is a test-only issue. I have fixed the new command plugin in the next version (which is still to be released). I have also submitted a pull request for your CSV project. Did you see that pull request?

adriens commented 5 years ago

Hi @sualeh , thanks for the PR that also fixes the runId and linTd issues ! 👍 I will release this we a new version to follow schemacrawler core software.