schemaorg / schemaorg

Schema.org - schemas and supporting software
https://schema.org/
Apache License 2.0
5.42k stars 825 forks source link

Usability/quality issues with Offer (price, gtin, ...) #99

Closed danbri closed 1 week ago

danbri commented 10 years ago

http://schema.org/Offer http://schema.org/price

(originally relayed from a colleague, Matthias)

Fixed already:

danbri commented 10 years ago

http://schema.org/productID is vague too; what should it contain?

"What are the allowed prefixes? isbn? gtin? ean? jan? upc? sku? mpn? is the colon mandatory? Is the prefix case sensitive?" (Matthias)

danbri commented 10 years ago

"From the parsing point of view, the best would be to have price without any grouping or cosmetic characters, in latin letters and the decimal point. And no currency mark, and currency being populated. i.e. 12345678.90" "the ascii requirement is important, the current spec allows (does not disallow) 12345 or 一二三四五六"

(from Matthias, the aforementioned colleague who raised this).

danbri commented 10 years ago

More detailed feedback around Offer from Matthias. These should be broken out into separate issues by logical group (availability, Actions, etc.), but for now just to record them in public:

danbri commented 9 years ago

I've left this overly general, semi-meta issue open for sdo-gozer. What specifics can we easily address for this current looming release? Other aspects need breaking out into their own issues and filing against Q2.

I'm aware also that a related question about area pricing - see https://github.com/schemaorg/schemaorg/wiki/PricingByArea - was only partially answered.

/cc @mfhepp

mfhepp commented 9 years ago

@danbri Thanks for CCing me. I admit I did not see this issue so far. Will try to address this for the post-gozer release. Martin

danbri commented 9 years ago

Yes, I don't see anything leaping forward to be included in the next release

github-actions[bot] commented 4 years ago

This issue is being tagged as Stale due to inactivity.

gmackenz commented 1 week ago

@danbri Should we close this issue as obsolete?

danbri commented 1 week ago

Yes

On Thu, 24 Oct 2024 at 17:22, Gordon Mackenzie @.***> wrote:

@danbri https://github.com/danbri Should we close this issue as obsolete?

— Reply to this email directly, view it on GitHub https://github.com/schemaorg/schemaorg/issues/99#issuecomment-2435728462, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABJSGIHWSFKMPBTQ7ZBA7DZ5ENEPAVCNFSM6AAAAABQRO4ST6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDIMZVG4ZDQNBWGI . You are receiving this because you were mentioned.Message ID: @.***>

gmackenz commented 1 week ago

Thanks for the quick response Dan, I am slowly checking all the long outstanding issues with the originators. Apologies but I lack the admin rights to be able close this issue myself.

MatthiasWiesmann commented 1 week ago

Closing this issue then.