schemaorg / suggestions-questions-brainstorming

Suggestions, questions, and brainstorming
19 stars 15 forks source link

Job Posting Schema: Salary element in example is wrong #154

Open generalreaction opened 6 years ago

generalreaction commented 6 years ago

The baseSalary element, as well as other elements, in the JSON example for JobPosting is incorrect and is not properly accepted in Structured Data Testing Tool.

Please try this edited markup for your example:

jaygray0919 commented 6 years ago

no errors; base salary is $10,000 US

generalreaction commented 6 years ago

That is interesting because Structured Data Testing Tool returns a warning for the baseSalary example used, as well as warnings and errors for other markup elements found in the Job Posting example. See attached image for reference.

errors in jobposting example

On Tue, Apr 24, 2018 at 2:18 PM, jay gray notifications@github.com wrote:

no errors; base salary is $10,000 US

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/schemaorg/schemaorg/issues/1897#issuecomment-384030749, or mute the thread https://github.com/notifications/unsubscribe-auth/Ak584Hs911oTNGCqltahRlerMvkNSyfJks5tr2x-gaJpZM4Th8s5 .

-- Alex Marco SEO Specialist amarco@neboagency.com

jaygray0919 commented 6 years ago

GSDTT: JobPosting 0 ERRORS 0 WARNINGS

generalreaction commented 6 years ago

So you copied the code snippet listed on http://schema.org/JobPosting and got no errors? I'm curious how GSDTT somehow works differently on your computer compared to mine. Especially considering the screen shot i shared is from GSDTT and was generated about today.

danbri commented 6 years ago

I do see see an error on the JSON-LD, same as @generalreaction 's screenshot. I see the same error for Microdata and RDFa too. @jaygray0919 - is it still fine for you? I will investigate at Google.

jaygray0919 commented 6 years ago

@danbri @generalreaction i ran the submission above - no errors.

when commenting, i did not run the schema example JobPosting.

i just ran that now and see the reported error re http://schema.org/JobPosting

the example for http://schema.org/JobPosting is wrong because the property baseSalary must be linked to a specific @Type and cannot be text.

In the example the value of the property is 10000, which is text.

the submission above is done correctly.

the example should be updated similar to the submission.

/jay

danbri commented 6 years ago

Ah... it seems some misunderstandings above then. When @generalreaction reaction wrote "Please try this edited markup for your example" it was a fix, so it wasn't expected to have an error. I don't think we've handled this particularly well at Google but the spirit of the error, and fix, makes sense, even though it is being overly strict in complaing about http://schema.org/baseSalary taking a number written as a string. It is much better to write currency information etc out explicitly, as we have also lately done around price.

RichardWallis commented 4 years ago

See issue #7 for the context of the move from the main Schema.org issue tracker to this repository.