schemar / solarc-theme

A flat theme with transparent elements. Based on the Arc theme: https://github.com/jnsh/arc-theme
GNU General Public License v3.0
114 stars 14 forks source link

Tooltip text difficult to read #38

Open pawanneupane opened 3 years ago

pawanneupane commented 3 years ago

I'm using SolArc-Dark theme on Arch Linux with Cinnamon DE. The only issue I've found is with tooltips as the tooltip texts are quite difficult to read. I've attached a screenshot of a tooltip in Nemo for reference, but it's the same in other applications too.

Is there a way to change the tooltip text color to make them more readable everywhere?

tooltiptext

schemar commented 3 years ago

Maybe. The way SolArc works is that it simply replaces colors. Check out solarize.sh to see what it does. The problem with changing that color is that it possibly breaks stuff elsewhere.

Do you know the original color in Arc or can you show a screenshot of the same notification in Arc? Though I am not very optimistic that we can get this fixed.

pawanneupane commented 3 years ago

This is a screenshot of the same notification in Arc-Dark, part of the arc-gtk-theme package from the official Arch repositories.

tooltiptextarcdark

schemar commented 3 years ago

Hmm, I see. Thanks. Can you get the color codes for Arc and SolArc tooltip background and foreground and compare them with what we have in solarize.sh?

The thing is that we only change colors without the context of where the color is used. So if we changed the color for the tooltip (which you could also try locally), there is a chance that something else becomes less readable.

Would it be possible for you to test another color from the solarized palette as foreground or background of the tooltip?

pawanneupane commented 3 years ago

I think I'll have to extract the gtk.gresource file to compare the color codes for gtk-3.0, but these are the color codes for gtk-2.0 in gtkrc:

SolArc-Dark:

gtk-color-scheme = "`tooltip_bg_color`: #4B5162"
gtk-color-scheme = "tooltip_fg_color: #fdf6e3"

Arc-Dark:

gtk-color-scheme = "tooltip_bg_color: #4B5162"
gtk-color-scheme = "tooltip_fg_color: #ffffff"

I hope this helps.

I'll also try with a different color from the solarized palette and let you know how it goes.

pawanneupane commented 3 years ago

After extracting the gtk.gresource files of both Arc-Dark and SolArc-Dark, this is what I found:

SolArc-Dark (gtk-main.css)

tooltip {
  border-radius: 2px;
  box-shadow: none; }
  tooltip.background {
    background-color: rgba(12, 92, 112, 0.95);
    background-clip: padding-box; }
    tooltip.background label {
      padding: 4px; }
  tooltip decoration {
    background-color: transparent; }
  tooltip * {
    background-color: transparent;
    color: #657b83; }

Arc-Dark (gtk-main-dark.css)

tooltip {
  border-radius: 2px;
  box-shadow: none; }
  tooltip.background {
    background-color: rgba(75, 81, 98, 0.95);
    background-clip: padding-box; }
    tooltip.background label {
      padding: 4px; }
  tooltip decoration {
    background-color: transparent; }
  tooltip * {
    background-color: transparent;
    color: #BAC3CF; }
schemar commented 3 years ago

Thank you for taking the time and figuring this out! What I meant was: would it be possible for you to clone this repository, change the relevant variables in solarize.sh and check if you can improve it or post a screenshot? That would be a tremendous help. I only have very few GTK apps anymore and cannot easily check (switched to KDE Plasma with i3wm and I am using the Nord color palette everywhere ...).

Let me know if you need help with the installation, but it should all be described in the README.

pawanneupane commented 3 years ago

Oh okay. I'm sorry I misunderstood it earlier. I'll test it as you suggested and get back to you. I might need your help with identifying the color code for tooltips in solarize.sh though. I had previously looked at the file and failed to figure out the tooltip text and background colors.

schemar commented 3 years ago

OK :ok_hand: Just let me know.