search

schemeway / SchemeScript

Scheme Editor plugin for Eclipse
http://schemeway.github.io/SchemeScript
Eclipse Public License 1.0
37 stars 9 forks source link

Implement support for R6RS inline escapes #8

Closed dobesv closed 9 years ago

dobesv commented 9 years ago

R6RS identifiers can contain any character by virtue of using an "inline escape". These inline escapes contain a semicolon, which confuses the ShemeWay scanner and partitioner. This patch prevents the semicolon in an inline escape from being treated as the start of a comment.

http://www.r6rs.org/final/html/r6rs/r6rs-Z-H-7.html#node_sec_4.2.4

schemeway commented 9 years ago

Very nice! Thanks a lot for this contribution. As soon as you fix the very small comment I made, I will merge it.

dobesv commented 9 years ago

Okay yeah somehow my formatting options were off at first. Will fix.

On Wed, Mar 11, 2015, 4:48 PM Dominique Boucher notifications@github.com wrote:

Very nice! Thanks a lot for this contribution. As soon as you fix the very small comment I made, I will merge it.

— Reply to this email directly or view it on GitHub https://github.com/schemeway/SchemeScript/pull/8#issuecomment-78397804.

dobesv commented 9 years ago

OK hopefully that does it. Do I need to do anything with the update site?

schemeway commented 9 years ago

I will do that. A few different things need to be done (updating the plugin version number, the feature version number, etc.). I will also create a tag.