scherzma commented 4 months ago

This pull request introduces a basic P2P network and SQLite storage implementation. Key changes include:

Started implementing P2P Network and Basic SQLite Storage.

Implemented basic network structures and message handling.
Added tests for network functionality and a test message operation.
Refactored code and improved the SyncMessageHandler.
Made small changes to the SecurityContext for future use. The goal is to establish the foundational components for the P2P network layer. This allows peers to connect, communicate, and synchronize messages. SQLite is used for local message storage.

Next steps will focus on expanding the network capabilities, enhancing security, and integrating with the higher-level application components. Additional testing will also be added.

Please review the code changes and provide any feedback or suggestions for improvement. Let me know if you have any questions!

Closes: #17 and Closes: #18 and related to #19

Reviewers: @JavaHammes

JavaHammes commented 4 months ago

Does this really close #17, #18, #19? I think that it works towards those issues but doesn't resolve them yet? Maybe I'm wrong.

scherzma commented 3 months ago

Does this really close #17, #18, #19? I think that it works towards those issues but doesn't resolve them yet? Maybe I'm wrong.

True, here my thoughts on each issue:

17: We can certainly close this one. The struct may change in the future, but i think we should just create a new issue if needed.

18: Also pretty much done. I will create a Ticket to document how data synchronisation is done.

19: Honestly, I'm not sure about that one. It's not exactly finished, but out of date. It was created a while ago and is not very specific. Should i update #19, or close it and create new issues for the problem?

JavaHammes commented 3 months ago

Does this really close #17, #18, #19? I think that it works towards those issues but doesn't resolve them yet? Maybe I'm wrong.

True, here my thoughts on each issue: #17: We can certainly close this one. The struct may change in the future, but i think we should just create a new issue if needed. #18: Also pretty much done. I will create a Ticket to document how data synchronisation is done. #19: Honestly, I'm not sure about that one. It's not exactly finished, but out of date. It was created a while ago and is not very specific. Should i update #19, or close it and create new issues for the problem?

Okay, then I would mark #17 and #18 as closed and then update #19 but don't mark it as closed.

scherzma / Skunk

Basic P2P Network functionality. #23

17: We can certainly close this one. The struct may change in the future, but i think we should just create a new issue if needed.

18: Also pretty much done. I will create a Ticket to document how data synchronisation is done.

19: Honestly, I'm not sure about that one. It's not exactly finished, but out of date. It was created a while ago and is not very specific. Should i update #19, or close it and create new issues for the problem?