schibsted / account-sdk-android

⛔️ DEPRECATED Schibsted Account SDK for Android
https://schibsted.github.io/account-sdk-android/
MIT License
14 stars 8 forks source link

Unnecessary dialog shown by Google SmartLock #393

Closed Nilzor closed 5 years ago

Nilzor commented 5 years ago

Disclaimer: I don't know the code well so I don't know if this is fixable

It looks like Google SmartLock shows an unnecessary and annoying dialog at the start of the singup flow in the following case:

The dialog looks like this

image

It basically asks us to choose which account "to continue with". I don't understand what selecting any of those actually does though.

When done entering a username and password, we get aske once again which account to store it in. This dialog is necessary and fine:

image

Finally note that when you do have a password stored in any of the configured accounts, the initial dialog int he flow looks like this (and is also fine)

image

In summary: I want someone to find out if we can drop the dialog illustrated at the top here, and still retain all the functionality of Google SmartLock. It would improve the user experience

Nilzor commented 5 years ago

Have you had a chance to look at this?

zamzterz commented 5 years ago

Yes, I finally got around to it now after vacation: The initial prompt is expected, see step 4 here, but it's supposed to result in the selected identifier being used/pre-filled in the login/signup flow. That was not working correctly, but has been fixed in #404.