Dismissing the SmartLock dialog causes reload of the username Activity

schibsted / account-sdk-android

⛔️ DEPRECATED Schibsted Account SDK for Android

https://schibsted.github.io/account-sdk-android/

MIT License

14 stars 8 forks source link

Dismissing the SmartLock dialog causes reload of the username Activity #405

Closed Nilzor closed 5 years ago

Nilzor commented 5 years ago

To reproduce:

Open the solution and modify the example app to ENABLE smart lock
Open the app, click login and click outside of the popup dialog from SmartLock
Notice how the acitvity restarts

zamzterz commented 5 years ago

This is intended in the example app implementation; the relevant parts is that 1) the SDK treating the [dismissal of SmartLock as a failure], and 2) the example app restarting the login with SmartLock disabled.

I agree it's a bit unnecessary to restart the Activity. Maybe we should treat dismissal of the dialog or any other failure related to SmartLock as a failure only if SmartLockMode.FORCED is used.

Nilzor commented 5 years ago

Sounds like a plan.

Note that it's not only the example app that is affected, but also production apps using the ui module

zamzterz commented 5 years ago

@Nilzor This has been fixed in #408, if you're able to help out with review/testing it would be great. 🙂