search

schibsted / account-sdk-browser

Schibsted Account SDK for browsers
https://schibsted.github.io/account-sdk-browser/
MIT License
16 stars 11 forks source link

identity: Send correct autologin parameter #11

Closed torarvid closed 6 years ago

torarvid commented 6 years ago

The hasSession and SPiD backends expect the autologin parameter to be either ‘0’ or ‘1’ (and not false/true). This used to be how the Identity class worked, but a recent refactoring introduced a bug there.

This commit refactors the unit tests for hasSession, adds tests for autologin, and fixes the issue.

codecov[bot] commented 6 years ago

Codecov Report

Merging #11 into master will increase coverage by 0.86%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #11      +/-   ##
==========================================
+ Coverage   58.87%   59.74%   +0.86%     
==========================================
  Files          17       17              
  Lines         462      462              
  Branches       81       83       +2     
==========================================
+ Hits          272      276       +4     
+ Misses        157      153       -4     
  Partials       33       33
Impacted Files Coverage Δ
src/identity.js 50.32% <100%> (+1.93%) :arrow_up:
src/SDKError.js 54.54% <0%> (+9.09%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 036046f...15d049d. Read the comment docs.