search

schibsted / account-sdk-browser

Schibsted Account SDK for browsers
https://schibsted.github.io/account-sdk-browser/
MIT License
16 stars 11 forks source link

simplifiedLoginWidget options should be optional #200

Closed ole-martin closed 3 years ago

ole-martin commented 3 years ago

New parameter in v4.4.0 breaks any existing implementation of showSimplifiedLoginWidget since the new option is not specified as optional even tho the code expects it to be optional

codecov[bot] commented 3 years ago

Codecov Report

Merging #200 (fe9d713) into master (223d857) will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #200   +/-   ##
=======================================
  Coverage   99.78%   99.78%           
=======================================
  Files          13       13           
  Lines         473      473           
  Branches       96       96           
=======================================
  Hits          472      472           
  Misses          1        1
Impacted Files Coverage Δ
src/identity.js 99.51% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 223d857...fe9d713. Read the comment docs.

ole-martin commented 3 years ago

PS: Is there any way to generate the d.ts files from the .js source? I've just done the changes manually for now.